Repository navigation
Fix #15237 (CI: run tests using cppcheck solutions docker images for ubuntu) - #9045
Conversation
dmcppcheck
left a comment
There was a problem hiding this comment.
AI review
I found no functional problems in the new workflow. It matches the steps in CI-unixish.yml, CI-unixish-docker.yml and scriptcheck.yml, and the packages it installs cover what those steps import or run. Three remarks:
- The 26.04 image is pinned to
:v1, but the PR description says:v3, like the other two images. One of them is wrong. - The
CMakeLists.txtchange has nothing to do with this workflow, which builds withmake. It only applies on CMake ≥ 4.5, so no CI job here runs it. - The workflow doesn't use ccache, unlike the other docker workflows. Each of the three images rebuilds everything from scratch on every PR.
There are no earlier comments to track.
Comments
| # | Comment | By | Where | Status |
|---|---|---|---|---|
| 1 | 26.04 image is pinned to :v1 but the PR description says :v3 | AI review | .github/workflows/cppchecksolutions-build.yml:27 |
🆕 New |
| 2 | No ccache: each of the 3 images does a full rebuild on every run | AI review | .github/workflows/cppchecksolutions-build.yml:51 |
🆕 New |
| 3 | Unrelated CMake change that no CI job in this PR exercises | AI review | CMakeLists.txt:7 |
🆕 New |
@danmar, please fix, resolve or reply to the open and new comments: #1, #2, #3.
Testing
- The PR changes no C++, Python or test sources:
diff -rq base prshows only the new workflow file andCMakeLists.txt. Because of that I didn't buildcppcheck/testrunneror write scratch inputs; it would only have tested base code. cmake -S . -B /tmp/b -Werror=devwith the PR'sCMakeLists.txtand CMake 3.28.3 configures cleanly (exit 0). The newif(CMAKE_VERSION VERSION_GREATER_EQUAL 4.5)block is skipped there, so I couldn't test thecmake_diagnostic(SET CMD_STRICT IGNORE RECURSE)call itself. No CMake ≥ 4.5 was available.- I checked by reading that the dependencies are covered:
- The Python imports used by test/cli, addons/test, test/tools (htmlreport uses pygments; reduce and donate_cpu need only the stdlib) are covered by the apt packages installed.
checkcfgskips its pkg-config- and xmlstarlet-dependent parts when those tools are missing.- The strace test in
test/cli/other_test.pyis covered by the strace package. - Using
-Werrorfor test/cli on 22.04 matches whatCI-unixish.ymlalready does on ubuntu-22.04.
- I couldn't run the workflow itself: there is no network access and none of the ghcr images are available.
Automated review of 870690c by Claude. The pull request was built and tested locally.
Add a CI-buildtools workflow. It runs on the
ghcr.io/cppchecksolutions/buildtools-ubuntu-{22.04,24.04,26.04}:v3
images and runs testrunner, the extra tests, test/cli, test/cfg,
XML validation, the addons tests and test/tools.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-authored-by: William Jakobsson <50847546+wjakobsson@users.noreply.github.com>
dmcppcheck
left a comment
There was a problem hiding this comment.
AI review
I found no new problems. The PR now only adds .github/workflows/cppchecksolutions-build.yml; the earlier CMakeLists.txt change has been dropped. I couldn't run the workflow, so I checked it by reading.
- The steps match
CI-unixish.yml,CI-unixish-docker.ymlandscriptcheck.yml. - Each test step gets the right
PYTHONPATH. - The installed packages cover the tools that the steps use (tidy, xmllint, pygments, strace).
One earlier comment is still in the code: the 26.04 image is pinned to :v1 while the description says :v3. That thread is marked resolved, but the line is unchanged.
Comments
| # | Comment | By | Where | Status |
|---|---|---|---|---|
| 1 | 26.04 image pinned to :v1 while description says :v3 | AI review | .github/workflows/cppchecksolutions-build.yml:27 |
☑️ Resolved, code unchanged |
| 2 | No ccache, each image rebuilds everything on every run | AI review | .github/workflows/cppchecksolutions-build.yml:51 |
💬 Answered: Author: object files can't be reused with any other job |
| 3 | Unrelated CMakeLists.txt change for CMake >= 4.5 | AI review | CMakeLists.txt:7 |
❔ Code removed |
| 4 | Use actions/checkout@v7 | @wjakobsson | .github/workflows/cppchecksolutions-build.yml:39 |
✅ Fixed |
Testing
- I didn't build
cppcheckortestrunnerand wrote no scratch tests.diff -rq base prshows that the PR only adds a workflow file, so a build would only have tested the base code. - I couldn't run the workflow itself. There is no network access and no ghcr buildtools images, and PyYAML isn't installed in the container, so I couldn't even parse the YAML.
- What I checked by reading:
test/tools/htmlreport/test_htmlreport.pyandcheck.share executable.check.shneedstidy,xmllintand the./cppcheckthat the workflow builds, and all three are there.- The Makefile targets
validateXMLandcheckCWEEntriesonly needxmllint(fromlibxml2-utils). - The
PYTHONPATHsettings and the-Werrorexception for 22.04 matchscriptcheck.yml.
- I couldn't confirm that the buildtools images contain
which; the Makefile uses it to find python3 and pcre2-config.
Automated review of 0fc6bec by Claude. The pull request was built and tested locally.
Add a CI-buildtools workflow. It runs on the
ghcr.io/cppchecksolutions/buildtools-ubuntu-{22.04,24.04,26.04} images and runs testrunner, the extra tests, test/cli, test/cfg, XML validation, the addons tests and test/tools.